Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
timothymcmackin
force-pushed
the
biel-search-only
branch
from
4896467 to
3f07b75
Compare
timothymcmackin
force-pushed
the
biel-search-only
branch
from
3f07b75 to
ef93049
Compare
NicNomadic
approved these changes
Jul 31, 2025
Collaborator
NicNomadic
left a comment
NicNomadic
left a comment
There was a problem hiding this comment.
LGTM beyond the eventual style adjustments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Biel search next to the Algolia search and match styles. This code is ugly and not a perfect style match because I'm not much for CSS; maybe we can get the design team to get it looking better.
One issue is that the search boxes do not appear the same at a moderate screen width, between full laptop and mobile. I'll keep looking at that.
One issue is that the behavior of the search windows is different; the Algolia search blurs out the whole page but Biel does not; I don't think I can work out how to do that with Biel. That's another issue for the design team.
Algolia:
Biel:
